Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make iter_dirs and iter_files yield items in alphabetical order #56

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

elemoine
Copy link
Contributor

@elemoine elemoine commented Feb 7, 2020

This PR makes the iter_dirs and iter_files functions yield their items in alphabetical order.

The tests/integration/test_files.py::test_iter_files test didn't pass for me because of that.

Successful PR Checklist:

  • Tests Not relevant
  • Documentation (optionally: run spell checking) Not relevant
  • Had a good time contributing? (feel free to give some feedback) First contribs always feel good 😄

@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #56 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   56.35%   56.35%           
=======================================
  Files          14       14           
  Lines         598      598           
  Branches       81       81           
=======================================
  Hits          337      337           
  Misses        254      254           
  Partials        7        7
Flag Coverage Δ
#integration 12.37% <100%> (ø) ⬆️
#unit 55.18% <0%> (ø) ⬆️
Impacted Files Coverage Δ
septentrion/files.py 86.79% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25e1e8c...7c8a8b4. Read the comment docs.

@ewjoachim ewjoachim merged commit 41a9923 into master Feb 7, 2020
@ewjoachim ewjoachim deleted the ele_iterdir branch February 7, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants