Fix version display in CLI #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k4nar
requested review from
ewjoachim,
mgu,
nadege and
samuelhamard
as code owners
k4nar
commented
Apr 3, 2020
| @@ -17,3 +17,6 @@ def from_string(cls, version_string: str) -> "Version": | |||
| except (AssertionError, ValueError) as exc: | |||
| raise exceptions.InvalidVersion(str(exc)) from exc | |||
| return cls(version_tuple=version_tuple, original_string=version_string) | |||
|
|
|||
| def __str__(self): | |||
| return self.original_string | |||
There was a problem hiding this comment.
An alternative would be to do '.'.join(self.version_tuple), but I think keeping the original string is less confusing for users.
k4nar
force-pushed
the
fix-version-display
branch
from
52d6916 to
f5fa2fc
Compare
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 71.75% 71.84% +0.08%
==========================================
Files 15 15
Lines 648 650 +2
Branches 87 87
==========================================
+ Hits 465 467 +2
Misses 171 171
Partials 12 12
Continue to review full report at Codecov.
|
ewjoachim
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful PR Checklist:
Before/After:
