chore(open-api-patcher): remove missed /api-docs path when using cors #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: github-actions <github-actions@github.com>
pflorek
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
When testing 0.0.151 on a real deployment, i saw that one trace is still in the export when using certain global cors settings for the ApiGateway.
Status quo on latest:
{"openapi":"3.0.1","info":{"title":"Default - Example RAD RestAPI","version":"2022-11-26T08:35:47Z"},"servers":[{"url":"https://q0f5v6zml3.execute-api.eu-west-1.amazonaws.com/{basePath}","variables":{"basePath":{"default":"v1"}}}],"paths":{"/public":{"options":{"responses":{"204":{"description":"204 response","headers":{"Access-Control-Allow-Origin":{"schema":{"type":"string"}},"Access-Control-Allow-Methods":{"schema":{"type":"string"}},"Access-Control-Allow-Headers":{"schema":{"type":"string"}}},"content":{}}}}},"/public/public":{"get":{"responses":{"200":{"description":"200 response","content":{"application/json":{"schema":{"$ref":"#/components/schemas/HelloWorldResponseModel"}}}}}},"options":{"responses":{"204":{"description":"204 response","headers":{"Access-Control-Allow-Origin":{"schema":{"type":"string"}},"Access-Control-Allow-Methods":{"schema":{"type":"string"}},"Access-Control-Allow-Headers":{"schema":{"type":"string"}}},"content":{}}}}},"/api-docs":{"options":{"responses":{"204":{"description":"204 response","headers":{"Access-Control-Allow-Origin":{"schema":{"type":"string"}},"Access-Control-Allow-Methods":{"schema":{"type":"string"}},"Access-Control-Allow-Headers":{"schema":{"type":"string"}}},"content":{}}}}},"/":{"options":{"responses":{"204":{"description":"204 response","headers":{"Access-Control-Allow-Origin":{"schema":{"type":"string"}},"Access-Control-Allow-Methods":{"schema":{"type":"string"}},"Access-Control-Allow-Headers":{"schema":{"type":"string"}}},"content":{}}}}}},"components":{"schemas":{"HelloWorldResponseModel":{"title":"HelloWorldResponse","type":"object","properties":{"isError":{"type":"boolean"},"message":{"type":"string"}},"description":""}}}}PR removes path:
/api-docsHowever works like charm thanks again for helping me out here to 💄 the swagger.ui 🙇
Cheers 🍻