Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coverage #5

Open
pflorek opened this issue Oct 31, 2022 · 0 comments
Open

Increase coverage #5

pflorek opened this issue Oct 31, 2022 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@pflorek
Copy link
Member

pflorek commented Oct 31, 2022

Have for each construct at least a very simple test

For example matching a snapshot:

https://github.com/pepperize/cdk-github/blob/main/test/github-custom-resource.test.ts

describe("GithubCustomResource", () => {
  it("Should match snapshot", () => {
    // Given
    const stack = new Stack();
    new GithubCustomResource(stack, "CR", {
      // ...
    });
    
    // When
    const template = Template.fromStack(stack);
    
    // Then
    expect(template).toMatchSnapshot();
  });
});
@pflorek pflorek added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 31, 2022
WtfJoke added a commit to WtfJoke/cdk-github-pepper that referenced this issue Nov 8, 2022
mergify bot pushed a commit that referenced this issue Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant