-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPG-454: set ready status when all pg pods are updated #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmm in other operators we didn't have this field and didn't have the same problem. I wonder what's the difference? |
I have removed this new field: 4e1cd4a |
egegunes
approved these changes
Sep 4, 2024
commit: 3b669b5 |
inelpandzic
approved these changes
Sep 5, 2024
hors
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPG-454
DESCRIPTION
Problem:
When pg instances are updated, the cluster status constantly switches between the
initializing
andready
states.Cause:
The operator sets the
ready
status when all pg pods are ready. They are updated one by one. After each update, all pods are ready, so the operator switches to theready
state.Solution:
Set the ready state when the sum of
.status.instances[].updatedReplicas
from crunchy'sPostgresCluster
is equal to the.status.postgres.size
.CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
Config/Logging/Testability