You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @jkmw !
Thanks for your contribution. But your code is not building. Please fix all issues and commit fix =)
P.S you can build docker image with Dockerfile in build directory
@jkmw
We fixed master branch. It had some issues with logging after PR merge.
But in any case, removing just one deprecated package should not change any logic inside operator.
I'd suggest to pull latest master and remove the deprecated package only, since this pr affects more parts than expected
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❨?❩
fixes https://jira.percona.com/browse/CLOUD-611
see kubernetes-sigs/controller-runtime#1107