Modified docker documentation #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastena1606
reviewed
Jul 9, 2024
documentation/docs/install.md
Outdated
| @@ -70,7 +70,9 @@ Install `pg_tde` using one of available installation methods: | |||
| docker run --name pg-tde -e POSTGRES_PASSWORD=mysecretpassword -d perconalab/pg_tde | |||
| ``` | |||
|
|
|||
| It builds and adds `pg_tde` extension to PostgreSQL 16. Relevant `postgresql.conf` and `tde_conf.json` are created in `/etc/postgresql/` inside the container. This directory is exposed as a volume. | |||
| It builds and adds `pg_tde` extension to PostgreSQL 16. The `postgresql.conf` contains the required modifications, and the extension is added to `template1` - with this, all new databases automatically have the `pg_tde` extension loaded. | |||
There was a problem hiding this comment.
Don't we mention where the postgresql.conf is stored inside the container anymore?
There was a problem hiding this comment.
That's a feature of the "upstream" docker image - do we want to mention it?
There was a problem hiding this comment.
We just mentioned it before. If it's not important / well known for Docker users/ brings no value to the user, we can omit it
nastena1606
reviewed
Jul 9, 2024
Co-authored-by: Anastasia Alexandrova <anastasia.alexandrova@percona.com>
Co-authored-by: Anastasia Alexandrova <anastasia.alexandrova@percona.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.