Move pg_tde files to one dir inside PGDATA #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dAdAbird
force-pushed
the
move-key-files
branch
2 times, most recently
from
69200ec to
74e6d08
Compare
dAdAbird
force-pushed
the
move-key-files
branch
from
c22b353 to
c51c611
Compare
We use tablespaceId as a part of IV for the internal keys encryption which doesn't add any security because dbId (used as well) is unique anyway. But having tablespaceId really complicates things as a principal created for the entire database but then different relations in this db can be located in different tablespaces... So it is better not to use tablespace with the principal key (database level) as it belongs to the relation level.
dAdAbird
force-pushed
the
move-key-files
branch
from
c51c611 to
34dd50b
Compare
dAdAbird
requested review from
codeforall and
dutow
and removed request for
dutow
codeforall
approved these changes
Nov 21, 2024
dutow
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid off table spaces references everywhere we can because having it really complicated things and made moving encrypted relation between table spaces really difficult. The main reason of the complexity is that a principal key and a keyring info are created and used in the scope entire database but different relations in the db can be located in different tablespaces. So we shouldn't use tablespaces there is a it (tablespace) belongs to the relation level.
That also means we shouldn't store keyring and internal key files in the database dir but move them to
PGDATA/pg_tde. The files layout looks like that:Fixes: PG-1209, PG-1196, PG-1208