Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG-1241 Documented KMIP integration and setup #368

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nastena1606
Copy link
Collaborator

Description

Documented KMIP integration and setup

modified: documentation/docs/_images/tde-flow.png
modified: documentation/docs/setup.md
modified: documentation/docs/tde.md

@nastena1606 nastena1606 requested review from dutow and dAdAbird December 4, 2024 16:40
@nastena1606 nastena1606 added the documentation Improvements or additions to documentation label Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

Performance test results:
Normal queries: 8822
TDE queries: 8585
Percentage: 97%
CSV entries: 1010312 pp-2019.csv
Sequential scan read times

HEAP: 1104.744
TDE: 1337.863 (121%)
TDE_BASIC: 1337.863 (161%)

@nastena1606 nastena1606 changed the title Documented KMIP integration and setup PG-1241 Documented KMIP integration and setup Dec 5, 2024
 modified:   documentation/docs/_images/tde-flow.png
        modified:   documentation/docs/setup.md
        modified:   documentation/docs/tde.md
documentation/docs/setup.md Outdated Show resolved Hide resolved
documentation/docs/setup.md Outdated Show resolved Hide resolved

* `provider-name` is the name of the provider. You can specify any name, it's for you to identify the provider.
* `kmip-IP` is the IP address of a domain name of the KMIP server
* The port to communicate with the KMIP server. When undefined, the default port 5696 is used
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently it is a required parameter, but making it optional is a good idea.

documentation/docs/setup.md Outdated Show resolved Hide resolved
@nastena1606 nastena1606 requested a review from dutow December 12, 2024 10:10

* `provider-name` is the name of the provider. You can specify any name, it's for you to identify the provider.
* `kmip-IP` is the IP address of a domain name of the KMIP server
* The port to communicate with the KMIP server. The default port is `5696`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still don't have a default port, it is a required parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants