Enhanced monitoring: set cloudwatch query maxInterval=60 sec #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlinevych
changed the title
JiriCtvrtka
approved these changes
Jul 20, 2021
There was a problem hiding this comment.
For me it is fine. We have 60 seconds intervals also in another places.
@askomorokhov Do you agree?
askomorokhov
approved these changes
Jul 20, 2021
|
Thanks for the review!
I kindly ask some of the collaborators to force-merge it. |
|
@denisok Can you merge it? Because of waiting for lint. |
|
@vlinevych, thank you for your contribution! Merged #63 |
denisok
added
community
award
|
@vlinevych Hello! We would love to send you a gift from Percona for your contributions. Please, contact us at community-team@percona.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation behind this PR is to reduce the number of requests to Cloudwatch, which are not cheap.
According to the current logic, refresh interval is set to the lowest value of
instance.EnhancedMonitoringIntervalfound among the instances.Although RDS supports the granularity of
1, 5, 10, 15, 30, or 60, the maxInterval is currently limited to 10 sec only.In my case, most of my instances are configured for 60sec and 5 out of 6 requests to Cloudwatch return the same data.
I would like to reevaluate the decision that was made back in 2018
Please let me know what do you think.
Thanks.