Add build info in percy-info (#1269)

* add build info in percy * fix tests * make coverage 100%
percy · Jun 2, 2023 · 1d0255c · 1d0255c
1 parent b9c3734
commit 1d0255c
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 0 deletions.
diff --git a/packages/core/src/api.js b/packages/core/src/api.js
@@ -140,6 +140,9 @@ export function createPercyServer(percy, port) {
       } else if (cmd === 'build-failure') {
         // the build-failure command will cause api errors to include a failed build
         percy.testing.build = { failed: true, error: 'Build failed' };
+      } else if (cmd === 'build-created') {
+        // the build-failure command will cause api errors to include a failed build
+        percy.testing.build = { id: '123', url: 'https://percy.io/test/test/123' };
       } else {
         // 404 for unknown commands
         return res.send(404);

diff --git a/packages/core/test/api.test.js b/packages/core/test/api.test.js
@@ -364,6 +364,8 @@ describe('API Server', () => {
       expect(percy.testing).toEqual({});
       await post('/test/api/build-failure');
       expect(percy.testing).toHaveProperty('build', { failed: true, error: 'Build failed' });
+      await post('/test/api/build-created');
+      expect(percy.testing).toHaveProperty('build', { id: '123', url: 'https://percy.io/test/test/123' });
       await post('/test/api/error', '/percy/healthcheck');
       expect(percy.testing).toHaveProperty('api', { '/percy/healthcheck': 'error' });
       await post('/test/api/disconnect', '/percy/healthcheck');

diff --git a/packages/sdk-utils/src/percy-enabled.js b/packages/sdk-utils/src/percy-enabled.js
@@ -12,6 +12,7 @@ export async function isPercyEnabled() {
       let response = await request('/percy/healthcheck');
       percy.version = response.headers['x-percy-core-version'];
       percy.config = response.body.config;
+      percy.build = response.body.build;
       percy.enabled = true;
     } catch (e) {
       percy.enabled = false;

diff --git a/packages/sdk-utils/test/helpers.js b/packages/sdk-utils/test/helpers.js
@@ -4,6 +4,7 @@ const helpers = {
   async setupTest({ logger = true } = {}) {
     utils.percy.version = '';
     delete utils.percy.config;
+    delete utils.percy.build;
     delete utils.percy.enabled;
     delete utils.percy.domScript;
     delete utils.logger.log.history;

diff --git a/packages/sdk-utils/test/index.test.js b/packages/sdk-utils/test/index.test.js
@@ -36,6 +36,7 @@ describe('SDK Utils', () => {
 
       beforeEach(async () => {
         await helpers.test('version', '1.2.3-beta.4');
+        await helpers.test('build-created');
         await expectAsync(isPercyEnabled()).toBeResolvedTo(true);
       });
 
@@ -51,6 +52,11 @@ describe('SDK Utils', () => {
       it('contains percy config', () => {
         expect(percy).toHaveProperty('config.snapshot.widths', [375, 1280]);
       });
+
+      it('contains percy build info', () => {
+        expect(percy.build).toHaveProperty('id', '123');
+        expect(percy.build).toHaveProperty('url', 'https://percy.io/test/test/123');
+      });
     });
   });