Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percy is not running, disabling snapshot #1459

Closed
KKonstantinov opened this issue Dec 8, 2023 · 4 comments · Fixed by #1463
Closed

Percy is not running, disabling snapshot #1459

KKonstantinov opened this issue Dec 8, 2023 · 4 comments · Fixed by #1463
Labels
🐛 bug Something isn't working

Comments

@KKonstantinov
Copy link

The problem

I'm running Percy with Playwright on node, and getting "Percy is not running, disabling snapshot" even though I can see in the logs Percy is starting up. This happens both on our CI/CD environment, and locally.

Environment

  • Node version: v18.18.2
  • @percy/cli version: 1.27.5
  • Version of Percy SDK you’re using:
  • If needed, a build or snapshot ID:
  • OS version: Ubuntu 20.04, MacOS Sonoma 14.1.1
  • Type of shell command-line [interface]: npx percy exec --debug --verbose -- npx playwright test --workers 1

Debug logs

npx percy exec --debug --verbose -- npx playwright test --workers 1
[percy:config] Found config file: .percy.yml (0ms)
[percy:config] Using config:
{
  version: 2,
  snapshot: {
    widths: [
      375,
      1280
    ],
    minHeight: 1024
  }
} (6ms)
[percy:core:install] Successfully downloaded Chromium 929475 (5600ms)
[percy:core:browser] Launching browser (2ms)
[percy:core:browser] Browser connected [62029]: HeadlessChrome/96.0.4664.0 (1176ms)
[percy:core] Percy has started! (1ms)
[percy:cli:exec] Running "npx playwright test --workers 1" (0ms)

Running 7 tests using 1 worker

  ✓  1 [setup] › _global.test.setup.ts:6:6 › Global Setup (as Test) (114ms)
[percy:utils] Percy is not running, disabling snapshots
[percy:utils] Error: connect ECONNREFUSED ::1:5338
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1555:16)
  ✓  2 [screenshot] › screenshot/screenshot.spec.ts:18:9 › Screenshots - not logged in › Register page (3.1s)
  ✓  3 [screenshot] › screenshot/screenshot.spec.ts:24:9 › Screenshots - not logged in › Login page (3.0s)
  ✓  4 [screenshot] › screenshot/screenshot.spec.ts:30:9 › Screenshots - not logged in › Empty cart page (6.4s)
  ✓  5 [screenshot] › screenshot/screenshot.spec.ts:67:9 › Screenshots - logged in › Cart page with item (14.1s)
  ✓  6 [screenshot] › screenshot/screenshot.spec.ts:77:9 › Screenshots - logged in › Checkout Flow (17.5s)
 ✓  7 [teardown] › _global.test.teardown.ts:6:9 › Global Teardown (as Test) (2.1s)
  7 passed (53.5s)
[percy:core:queue] Clearing discovery queue, queued state: 0, pending state: 0 (54346ms)
[percy:core:browser] Closing browser (0ms)
[percy:core:browser] Browser closed (14ms)
[percy:core:queue] Clearing snapshot queue, queued state: 0, pending state: 0 (1ms)
[percy:core] Build not created (0ms)
@itsjwala
Copy link
Contributor

we'll be checking this today.

@itsjwala itsjwala added the 🐛 bug Something isn't working label Dec 11, 2023
@itsjwala
Copy link
Contributor

Okay so we've narrowed the issue, its related to following PR #1447

this would be breaking post node version 17+ nodejs/node#40702 (comment)

We'll send out a patch by end of this week, please resort to previous stable version till then, thankyou!

@itsjwala
Copy link
Contributor

FYI we've released a patch as per our release process in beta v1.27.6-beta.0 we'll do a stable release by end of this/next week.

@daveverwer
Copy link

Thanks for fixing this! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants