✨ Check review-state in build:wait

[AaronBuxbaum]

• build:wait when used with --fail-on-changes exits CLI with non-zero code, when the build is approved, ideally we'd want to exit 0
• This PR adds an additional flag --pass-if-approved which will exit 0 when the build is approved even when diffs are found.
• This flag only works when --fail-on-changes is passed

[itsjwala]

Thanks for the contribution, we'll review it in some time.

[itsjwala]

back to you @AaronBuxbaum

[itsjwala]

Nice @AaronBuxbaum!

I've left some additional comments, post which we're gtg

[AaronBuxbaum]

@itsjwala ready to go!

Not sure how, but I was seeing these tests fail:

stops waiting on process termination
logs an error when there are no snapshots

I updated them to pass, but give them a look and make any updates desired. then we can push this across the finish line. It might just be my local configuration!

[AaronBuxbaum]

@itsjwala ready to go!

Not sure how, but I was seeing these tests fail:

stops waiting on process termination
logs an error when there are no snapshots

I updated them to pass, but give them a look and make any updates desired. then we can push this across the finish line. It might just be my local configuration!

based on CI, it looks like it might be my local configuration. Made a commit to remove those changes.

[itsjwala]

Thanks for your contribution @AaronBuxbaum 🔥

Merging this PR (windows CI are known to be flaky) , This will be part of 1.21.0 release ETA end of week.