Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Race Condition incase of Screenshot Cmd #1793

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Fixing Race Condition incase of Screenshot Cmd #1793

merged 2 commits into from
Nov 27, 2024

Conversation

Amit3200
Copy link
Contributor

  • Fixing Race Condition incase of Screenshot Cmd
  • Currently when calling percyScreenshot command the tasks were getting deleted as we used to find them using snapshot name.
  • Since in screenshot command we upload comparisons they are allowed to have same snapshot name so now deletion cannot work, so we need to add find with tag name.

@Amit3200 Amit3200 marked this pull request as ready for review November 25, 2024 13:33
@Amit3200 Amit3200 requested a review from a team as a code owner November 25, 2024 13:33
@Amit3200 Amit3200 merged commit cd2e26e into master Nov 27, 2024
36 checks passed
@Amit3200 Amit3200 deleted the bugfix/sync-issues branch November 27, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@this-is-shivamsingh this-is-shivamsingh this-is-shivamsingh approved these changes

@chinmay-browserstack chinmay-browserstack chinmay-browserstack approved these changes

@pankaj443 pankaj443 pankaj443 approved these changes

@ninadbstack ninadbstack Awaiting requested review from ninadbstack ninadbstack is a code owner automatically assigned from percy/percy-product-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Amit3200 @pankaj443 @chinmay-browserstack @this-is-shivamsingh