Skip to content

Commit

Permalink
adding tests
Browse files Browse the repository at this point in the history
  • Loading branch information
prklm10 committed Jan 21, 2024
1 parent 35e24b8 commit 5e6acb1
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
4 changes: 2 additions & 2 deletions tests/test_app_automate.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def test_app_automate_execute_percy_screenshot_begin(self, _mocked_log):

def test_app_automate_execute_percy_screenshot_end(self):
self.mock_webdriver.execute_script.return_value = {}
self.assertIsNone(self.app_automate.execute_percy_screenshot_end('Screenshot 1', self.comparison_response['link'], 'success'))
self.assertIsNone(self.app_automate.execute_percy_screenshot_end('Screenshot 1', self.comparison_response['link'], 'success', False))
self.mock_webdriver.execute_script.assert_called()

def test_app_automate_execute_percy_screenshot(self):
Expand All @@ -62,7 +62,7 @@ def test_app_automate_execute_percy_screenshot(self):
@patch('percy.providers.app_automate.log')
def test_execute_percy_screenshot_end_throws_error(self, mock_log):
self.mock_webdriver.execute_script.side_effect = Exception('SomeException')
self.app_automate.execute_percy_screenshot_end('Screenshot 1', 'snapshot-url', 'success')
self.app_automate.execute_percy_screenshot_end('Screenshot 1', 'snapshot-url', 'success', False)
mock_log.assert_called()

@patch.object(Metadata, 'session_id', PropertyMock(return_value='unique_session_id'))
Expand Down
6 changes: 4 additions & 2 deletions tests/test_cli_wrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def test_request_body(self):
name = "some-name"
debug_url = "debug-url"
response = self.cli_wrapper._request_body(
name, tag, [tile], debug_url, self.ignored_elements_data, self.considered_elements_data
name, tag, [tile], debug_url, self.ignored_elements_data, self.considered_elements_data, False
)
self.assertEqual(response["name"], name)
self.assertEqual(response["external_debug_url"], debug_url)
Expand All @@ -118,6 +118,7 @@ def test_request_body(self):
self.assertDictEqual(
response["considered_elements_data"], self.considered_elements_data
)
self.assertEqual(response["sync"], False)

def test_request_body_when_optional_values_are_null(self):
tile = Tile("some-file-path", 10, 10, 20, 20)
Expand All @@ -127,10 +128,11 @@ def test_request_body_when_optional_values_are_null(self):
ignored_elements_data = None
considered_elements_data = None
response = self.cli_wrapper._request_body(
name, tag, [tile], debug_url, ignored_elements_data, considered_elements_data
name, tag, [tile], debug_url, ignored_elements_data, considered_elements_data, True
)
self.assertEqual(response["name"], name)
self.assertEqual(response["external_debug_url"], debug_url)
self.assertDictEqual(response["tag"], tag)
self.assertListEqual(response["tiles"], [dict(tile)])
self.assertEqual(response["ignored_elements_data"], None)
self.assertEqual(response["sync"], True)
2 changes: 1 addition & 1 deletion tests/test_generic_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def test_post_screenshots(self):
tag = self.generic_provider._get_tag()
tiles = self.generic_provider._get_tiles()
response = self.generic_provider._post_screenshots(
"screenshot 1", tag, tiles, "", [], []
"screenshot 1", tag, tiles, "", [], [], False
)
self.assertEqual(response, self.comparison_response)

Expand Down

0 comments on commit 5e6acb1

Please sign in to comment.