Skip to content

Commit

Permalink
keeping names consistent
Browse files Browse the repository at this point in the history
  • Loading branch information
prklm10 committed Mar 28, 2024
1 parent 84aaf19 commit 8392924
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
10 changes: 6 additions & 4 deletions percy/lib/cli_wrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ def is_percy_enabled():
return False

def post_screenshots(self, name, tag, tiles, external_debug_url=None,
ignored_elements_data=None, considered_elements_data=None, sync=None, test_case=None, th_execution_id=None
ignored_elements_data=None, considered_elements_data=None, sync=None, test_case=None, th_test_case_execution_id=None
):
body = self._request_body(name, tag, tiles, external_debug_url,
ignored_elements_data, considered_elements_data, sync, test_case, th_execution_id
ignored_elements_data, considered_elements_data, sync, test_case, th_test_case_execution_id
)

body['client_info'] = Environment._get_client_info()
Expand Down Expand Up @@ -104,7 +104,9 @@ def post_poa_screenshots(self, name, session_id, command_executor_url, capabilit
return data.get('data', {})

@staticmethod
def _request_body(name, tag, tiles, external_debug_url, ignored_elements_data, considered_elements_data, sync, test_case, th_execution_id):
def _request_body(name, tag, tiles, external_debug_url, ignored_elements_data,
considered_elements_data, sync, test_case, th_test_case_execution_id
):
tiles = list(map(dict, tiles))
return {
"name": name,
Expand All @@ -115,5 +117,5 @@ def _request_body(name, tag, tiles, external_debug_url, ignored_elements_data, c
"considered_elements_data": considered_elements_data,
"sync": sync,
"test_case": test_case,
"th_test_case_execution_id": th_execution_id
"th_test_case_execution_id": th_test_case_execution_id
}
5 changes: 3 additions & 2 deletions percy/providers/generic_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,9 @@ def get_regions_by_location(self, elements_array, custom_locations):
log(f"Values passed in custom ignored region at index: {idx} is not valid")

@staticmethod
def _post_screenshots(name, tag, tiles, debug_url, ignored_regions, considered_regions, sync, test_case, th_execution_id):
response = CLIWrapper().post_screenshots(name, tag, tiles, debug_url, ignored_regions, considered_regions, sync, test_case, th_execution_id)
def _post_screenshots(name, tag, tiles, debug_url, ignored_regions, considered_regions, sync, test_case, th_test_case_execution_id):
response = CLIWrapper().post_screenshots(name, tag, tiles, debug_url, ignored_regions,
considered_regions, sync, test_case, th_test_case_execution_id)
return response

def _write_screenshot(self, png_bytes, directory):
Expand Down

0 comments on commit 8392924

Please sign in to comment.