fix: Only log healthcheck fail when LOG_LEVEL=debug is set
#101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robdel12
commented
Jul 3, 2019
| @@ -66,6 +66,11 @@ def self._get_agent_js | |||
|
|
|||
| def self._make_dom_snapshot(page) | |||
| agent_js = self._get_agent_js | |||
|
|
|||
| if self._is_debug? | |||
| self._logger.info { "agent_js file: #{agent_js}" } | |||
There was a problem hiding this comment.
Added this log because it's been really helpful to know what this is while debugging various integrations with customers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
If you're running your test suite without percy started, these health check logs would be very noisy and annoying. This PR will make it so they only log if you're setting the log level to
debug.