Require Percy version file specifically #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If other version.rb files are in the load path, then it'll load them instead leading to fun conflicts (error message in Rails is along the lines of: `Unable to autoload constant VERSION...`) This requires the Percy version file specifically. I believe other gems have solved this by using a subfolder under `/lib` that contains the Gem name rather than adding generic files in `lib` to the load path which might cause more fun errors in future :) Happy to send a PR with that change too if you'd like!
Robdel12
approved these changes
Jul 23, 2019
|
Thanks @nikz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If other version.rb files are in the load path, then it'll load them
instead leading to fun conflicts (error message in Rails is along the
lines of:
Unable to autoload constant VERSION...)This requires the Percy version file specifically. I believe other gems
have solved this by using a subfolder under
/libthat contains the Gemname rather than adding generic files in
libto the load path whichmight cause more fun errors in future :) Happy to send a PR with that
change too if you'd like!