Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Pass snapshot options #170

Merged
merged 1 commit into from
Jun 10, 2021
Merged

🐛 Pass snapshot options #170

merged 1 commit into from
Jun 10, 2021

Conversation

Robdel12
Copy link
Contributor

@Robdel12 Robdel12 commented Jun 10, 2021

What is this?

Big oof, when building the SDK I forgot to pass the rest of the options to thesnapshot endpoint. It had 100% coverage..! 😐 Will close #169

@Robdel12 Robdel12 requested a review from wwilsman June 10, 2021 15:46
Big oof, when building the SDK I forgot to pass the rest of th options to the
`snapshot` endpoint.
@Robdel12 Robdel12 force-pushed the rd/pass-snapshot-options branch from fb13766 to 0012c1e Compare June 10, 2021 15:46
Copy link
Contributor

@wwilsman wwilsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎮

@Robdel12 Robdel12 merged commit 41695f6 into master Jun 10, 2021
@Robdel12 Robdel12 deleted the rd/pass-snapshot-options branch June 10, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per-snapshot widths not respected in 5.0.0.pre.4
2 participants