Add Ember CLI Rails Loader

[djones]

Adds support for loading in assets from both Ember and Rails when using Ember CLI Rails

Configuration

In your spec_helper.rb file you need to configure use of this loader like so:

RSpec.configure do |config|
  # ...
  config.before(:suite) do
    # Ember CLI must compile first to create all the required files.
    EmberCli.compile!

    # You need to tell the loader which apps are mounted on which paths.
    ember_apps = { frontend: '/', admin: '/admin/' }

    Percy::Capybara.use_loader(:ember_cli_rails, { mounted_apps: ember_apps})

    Percy::Capybara.initialize_build
  end

  config.after(:suite) { Percy::Capybara.finalize_build }
end

You would have the above configuration if you have something like this in your routes.rb file:

Rails.application.routes.draw do
  # Useful for just subbing in a vanilla Rails controller for testing.
  # root to: 'pages#index'

  mount_ember_app :admin, to: "/admin", controller: "admin"
  mount_ember_app :frontend, to: "/"
end

Example App

percy/example-ember-cli-rails#1

Todo

• write tests for Percy::Capybara::Loaders::EmberCliRailsLoader

[fotinakis]

@djones Nice work, this looks excellent.

Two tiny comments above. Also, whatever happened to the EmberCli.compile! step?

[fotinakis]

This won't work on Windows because this is a URL and File.join uses the OS path separator instead of always forward slashes, so you'll get \main.css. Need to find a URL joiner or use the old join code.

[fotinakis]

Optional: could you rename this to _resources_from_dir and root_dir arg for clarity / slightly more consistency with some other places in the code.

[djones]

@fotinakis cool, will do that.

[fotinakis]

Ahh I see that EmberCli.compile! is a manual setup step outside. That's 👍 for now.

[djones]

@fotinakis yeah, and honestly I think that is the right approach anyway. Feels weird for the loader to fire off asset compilation.

[fotinakis]

LGTM! 🍰 🎉