Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load all resources from Ember CLI Rails #36

Merged
merged 3 commits into from
May 24, 2017
Merged

Load all resources from Ember CLI Rails #36

merged 3 commits into from
May 24, 2017

Conversation

djones
Copy link
Contributor

@djones djones commented May 23, 2017

  • Don't limit ourselves to just resources in Ember's /assets dist dir. Sometimes resources can be in the root or fonts dir for example.
  • Handle duplicated assets gracefully when the same URI is used over multiple Ember and Rails apps

@djones djones requested a review from fotinakis May 23, 2017 21:04
fotinakis
fotinakis approved these changes May 24, 2017
View reviewed changes
Copy link
Contributor

@fotinakis fotinakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 👍

@djones djones merged commit ca489d6 into master May 24, 2017
@fotinakis fotinakis deleted the include_all_resources_from_ember_cli branch May 25, 2017 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fotinakis fotinakis fotinakis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djones @fotinakis