Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to token only build creation endpoint #55

Merged
merged 9 commits into from
Sep 6, 2018

Conversation

maprules1000
Copy link
Contributor

Removes checks for PERCY_PROJECT to enable support for the new token only build creation endpoint.

Note: this will be updated with the new percy-client gem before it is shipped.
percy/percy-client#39

@maprules1000 maprules1000 force-pushed the map/update-to-token-only-build-endpoint branch from d4db432 to ac31928 Compare August 24, 2018 22:19
@maprules1000 maprules1000 force-pushed the map/update-to-token-only-build-endpoint branch from 2c1fcf7 to 902f434 Compare September 4, 2018 20:35
@fotinakis fotinakis self-requested a review September 6, 2018 17:18
Copy link
Contributor

@fotinakis fotinakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮 with one comment below

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
spec.require_paths = ['lib']

spec.add_dependency 'percy-client', '~> 1.13'
spec.add_dependency 'percy-client', '~> 2.0.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be only ~> 2.0 not 2.0.0 I believe, in order for us to allow 2.X releases and not just 2.0.X releases.

@maprules1000 maprules1000 merged commit 753b586 into master Sep 6, 2018
@maprules1000 maprules1000 deleted the map/update-to-token-only-build-endpoint branch September 6, 2018 19:55
@joscha
Copy link

joscha commented Sep 21, 2018

for people still being on older clients, PERCY_TOKEN is still needed? I think some documentation about why the PERCY_TOKEN was removed and in which version it is not needed any more would be great. I found this pull request after being confused about why the settings page of a project doesn't show the project any more. We still have a few older clients out there (storybook and capybara) which would need updating first before we can leave out the project. I used <organization>/<slug> in the meantime for new projects with old clients and hope that will work? //cc @timhaines

references percy/percy-storybook#44

@maprules1000
Copy link
Contributor Author

maprules1000 commented Sep 24, 2018

Hey @joscha! Older clients still do need both PERCY_TOKEN and PERCY_PROJECT. The most recent version of percy-capybara removed the need for the PERCY_PROJECT env variable. New projects that use the project variable will still work without a hitch since the percy client will just not look for it, but the token variable is still required.

I've updated the release notes for this library to specifically call out the removal of PERCY_PROJECT as well. https://github.com/percy/percy-capybara/releases/tag/v3.2.0

I hope that clears everything up!

@joscha
Copy link

joscha commented Sep 24, 2018

@maprules1000 is the way to get to the project I described above correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants