-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to token only build creation endpoint #55
Conversation
d4db432
to
ac31928
Compare
2c1fcf7
to
902f434
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌮 with one comment below
percy-capybara.gemspec
Outdated
@@ -18,7 +18,7 @@ Gem::Specification.new do |spec| | |||
spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) | |||
spec.require_paths = ['lib'] | |||
|
|||
spec.add_dependency 'percy-client', '~> 1.13' | |||
spec.add_dependency 'percy-client', '~> 2.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be only ~> 2.0
not 2.0.0
I believe, in order for us to allow 2.X
releases and not just 2.0.X
releases.
for people still being on older clients, references percy/percy-storybook#44 |
Hey @joscha! Older clients still do need both I've updated the release notes for this library to specifically call out the removal of I hope that clears everything up! |
@maprules1000 is the way to get to the project I described above correct? |
Removes checks for
PERCY_PROJECT
to enable support for the new token only build creation endpoint.Note: this will be updated with the new
percy-client
gem before it is shipped.percy/percy-client#39