fix: Enable JavaScript for builds #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djones
reviewed
May 23, 2019
djones
reviewed
May 23, 2019
djones
reviewed
May 23, 2019
| @@ -39,16 +40,20 @@ | |||
| visit 'http://example.com' | |||
| Percy.snapshot(page, { name: 'minHeight', minHeight: 2000 }) | |||
| end | |||
| it 'recognizes enableJavascript' do | |||
| visit 'http://example.com' | |||
There was a problem hiding this comment.
This won't actually show anything different with JS on or off. In a follow up PR let's move to testing with https://github.com/percy/sdk-test-website and we can add JS detection to that site.
There was a problem hiding this comment.
Yeah, that's the TODO in my PR description. Can you give the SDK team access to that repo? It 404s for me at the moment.
I'm thinking we're going to need to add something like canvas since that isn't captured by our SDKs yet and requires JS to build the element.
djones
approved these changes
May 23, 2019
There was a problem hiding this comment.
🍍 LGTM. I'll write a follow up PR to change this test suite to make use of https://github.com/percy/sdk-test-website since that feels like it's out of scope of this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Looks like the key that was being passed isn't using the right casing for
@percy/agent.enableJavascriptis deprecated and apparently doesn't work.enableJavaScriptis the correct way and does work.TODO
What's a good test for this that would surface JS not working in a snapshot? Probably introduce our own page?