Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Update SDK to use Node 14 & dynamic import #331

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Conversation

Robdel12
Copy link
Contributor

@Robdel12 Robdel12 commented Apr 6, 2022

What is this?

With CLI 1.x being released, the final breaking change that we made was to migrate to ESM to align with the new future of Node (given we support Node 14+ now). This PR updates the SDK utils package to be a dynamic import inside of the SDK.

@Robdel12 Robdel12 added the 🐛 bug Something isn't working label Apr 6, 2022
@Robdel12 Robdel12 requested a review from wwilsman April 6, 2022 19:02
@Robdel12 Robdel12 enabled auto-merge (squash) April 6, 2022 19:16
Copy link
Contributor

@wwilsman wwilsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎮 🎉

@Robdel12 Robdel12 merged commit 7e233b0 into master Apr 6, 2022
@Robdel12 Robdel12 deleted the rd/esm-sdk-utils branch April 6, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants