Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for responsive snapshot capture #18

Merged
merged 11 commits into from
Oct 4, 2024

Conversation

chinmay-browserstack
Copy link
Contributor

@chinmay-browserstack chinmay-browserstack commented Oct 1, 2024

  • Added option for responsiveSnapshotCapture. when this option is passed as true, we will capture dom in all widths returned by CLI.
  • resize browser window using set_window_size for selenium 3 or non chrome browsers else using cdp to resize window. reason: in chrome we can only resize window upto 500px so to bypass this we are using cdp but running cdp command in selenium 3 is not supported.
  • collect cookies using selenium driver.
  • Send logs to cli via /percy/log endpoint

lib/percy.rb Show resolved Hide resolved
pankaj443
pankaj443 previously approved these changes Oct 4, 2024
Copy link

@pankaj443 pankaj443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ninadbstack ninadbstack merged commit 71cfa58 into main Oct 4, 2024
3 checks passed
@ninadbstack ninadbstack deleted the responsive_snapshot_capture_support branch October 4, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants