Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook v8 upgrade #940

Merged
merged 8 commits into from
May 7, 2024
Merged

Storybook v8 upgrade #940

merged 8 commits into from
May 7, 2024

Conversation

rishigupta1599
Copy link
Contributor

@rishigupta1599 rishigupta1599 commented May 6, 2024 •
edited
Loading

Needed following changes for storybook v8 support and some changes to make future changes generic -

  1. Node version upgrade to 18, must have requirement for v8.
  2. The StoryStore (STORYBOOK_STORY_STORE and STORYBOOK_PREVIEW.storyStore) are deprecated, store.raw() need to be replaced with STORYBOOK_PREVIEW.extract() instead. https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#storystore-and-methods-deprecated
  3. Upgraded @percy/cli-command to latest 1.28.5 version for latest compatibility.
  4. "jackspeak": "2.1.1" need to be set as per bug in yarn 1 , [Bug]: string-width dependency stops storybook from executing storybookjs/storybook#22431.

@rishigupta1599 rishigupta1599 marked this pull request as ready for review May 7, 2024 04:56
@rishigupta1599 rishigupta1599 requested a review from a team as a code owner May 7, 2024 04:56
@rishigupta1599 rishigupta1599 requested review from prklm10, ninadbstack, a team, yashdsaraf and chinmay-browserstack and removed request for a team May 7, 2024 04:56
ninadbstack
ninadbstack approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@ninadbstack ninadbstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! btw do you think we should do a percy e2e test setup for this ?

@Amit3200
Copy link

Amit3200 commented May 7, 2024

LGTM 🍍

@rishigupta1599 rishigupta1599 merged commit 1e64e21 into master May 7, 2024
6 checks passed
@rishigupta1599 rishigupta1599 deleted the storybook_v8_upgrade branch May 7, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinmay-browserstack chinmay-browserstack chinmay-browserstack approved these changes

@ninadbstack ninadbstack ninadbstack approved these changes

@Amit3200 Amit3200 Amit3200 approved these changes

@prklm10 prklm10 Awaiting requested review from prklm10 prklm10 is a code owner automatically assigned from percy/percy-product-reviewers

@yashdsaraf yashdsaraf Awaiting requested review from yashdsaraf yashdsaraf was automatically assigned from percy/percy-platform-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rishigupta1599 @Amit3200 @ninadbstack @chinmay-browserstack