Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor 2 #3

Merged
merged 9 commits into from
May 19, 2024
Merged

Refactor 2 #3

merged 9 commits into from
May 19, 2024

Conversation

qgallouedec
Copy link
Collaborator

No description provided.

@qgallouedec qgallouedec mentioned this pull request May 19, 2024
Closed
6 tasks
@qgallouedec
Copy link
Collaborator Author

For now I've dropped the use of the reward module, but can still add it back later if we want a support for diverse reward functions (not sure if it's useful though)

@perezjln perezjln merged commit 36b3105 into main May 19, 2024
0 of 24 checks passed
@perezjln perezjln deleted the qgallouedec/refactor_2 branch May 19, 2024 22:03
@perezjln
Copy link
Owner

perezjln commented May 19, 2024

For now I've dropped the use of the reward module, but can still add it back later if we want a support for diverse reward functions (not sure if it's useful though)

I took the idea of a dedicated reward library in manipulation from the meta-world paper and framework (https://meta-world.github.io/) - I will make a post on the slack on that subject - let's make it as you suggest for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants