Support for foreign architecture images #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating Unibuild images in the bases, need to use full sha256 for multiarch.
| bash /ddb-entrypoint --user-ent "${USER_ENT}" | ||
|
|
||
| if ${LOGIN_AFTER} | ||
| then | ||
| # Wait a bit for the container to boot properly |
There was a problem hiding this comment.
I'd suggest that login be modified to spin on docker exec /bin/true being successful for up to, say, 30 seconds, before attempting to run bash. The fixed 2-second interval invites a race condition for other containers that take longer.
| @@ -83,4 +83,4 @@ RUN echo "${CONTAINER_NAME}" > "${CONTAINER_NAME}" | |||
| EOF | |||
|
|
|||
| cd "${TMPBASE}" | |||
| $DOCKER build --pull -t "${CONTAINER_NAME}" -f "${DOCKERFILE}" . | |||
| $DOCKER buildx build --pull -t "${CONTAINER_NAME}" -f "${DOCKERFILE}" . | |||
There was a problem hiding this comment.
Should this use --platform?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables building and booting foreign architecture images. You need to have a builder that supports multi-architectures.