Rename underscore methods to make stickler happy

perftools · Dec 23, 2020 · fb74ebd · fb74ebd
1 parent 86cb4d8
commit fb74ebd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/src/Profile.php b/src/Profile.php
@@ -40,7 +40,7 @@ public function __construct(array $profile, $convert = true)
         }
 
         if (!empty($profile['profile']) && $convert) {
-            $this->_process();
+            $this->process();
         }
     }
 
@@ -51,7 +51,7 @@ public function __construct(array $profile, $convert = true)
      * method are aggregated. We are not able to maintain a full tree structure
      * in any case, as xhprof only keeps one level of detail.
      */
-    protected function _process(): void
+    private function process(): void
     {
         $result = [];
         foreach ($this->data['profile'] as $name => $values) {
@@ -575,7 +575,7 @@ public function getCallgraph($metric = 'wt', $threshold = 0.01)
         }
 
         $this->visited = $this->nodes = $this->links = [];
-        $this->_callgraphData(self::NO_PARENT, $main, $metric, $threshold);
+        $this->callgraphData(self::NO_PARENT, $main, $metric, $threshold);
         $out = [
             'metric' => $metric,
             'total' => $main,
@@ -587,7 +587,7 @@ public function getCallgraph($metric = 'wt', $threshold = 0.01)
         return $out;
     }
 
-    protected function _callgraphData($parentName, $main, $metric, $threshold, $parentIndex = null): void
+    private function callgraphData($parentName, $main, $metric, $threshold, $parentIndex = null): void
     {
         // Leaves don't have children, and don't have links/nodes to add.
         if (!isset($this->indexed[$parentName])) {
@@ -629,7 +629,7 @@ protected function _callgraphData($parentName, $main, $metric, $threshold, $pare
             // If the current function has more children,
             // walk that call subgraph.
             if (isset($this->indexed[$childName]) && !$revisit) {
-                $this->_callgraphData($childName, $main, $metric, $threshold, $index);
+                $this->callgraphData($childName, $main, $metric, $threshold, $index);
             }
         }
     }

diff --git a/src/ServiceContainer.php b/src/ServiceContainer.php
@@ -43,11 +43,11 @@ public function __construct()
         parent::__construct();
         $this->setupPaths($this);
         $this->register(new ConfigProvider());
-        $this->_slimApp();
-        $this->_services();
+        $this->slimApp();
+        $this->services();
         $this->storageDriverPdo($this);
         $this->storageDriverMongoDb($this);
-        $this->_controllers();
+        $this->controllers();
     }
 
     public function boot(): void
@@ -66,7 +66,7 @@ private function setupPaths(self $app): void
     }
 
     // Create the Slim app.
-    protected function _slimApp(): void
+    private function slimApp(): void
     {
         $this['view'] = static function ($c) {
             // Configure Twig view for slim
@@ -111,7 +111,7 @@ protected function _slimApp(): void
     /**
      * Add common service objects to the container.
      */
-    protected function _services(): void
+    private function services(): void
     {
         $this['searcher'] = static function ($c) {
             $saver = $c['config']['save.handler'];
@@ -221,7 +221,7 @@ private function storageDriverMongoDb(Container $app): void
     /**
      * Add controllers to the DI container.
      */
-    protected function _controllers(): void
+    private function controllers(): void
     {
         $this['watchController'] = $this->factory(static function ($c) {
             return new Controller\WatchController($c['app'], $c['searcher']);