-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker installation #231
Conversation
Signed-off-by: Jacob Kiers <kiers@comandi.nl>
@@ -0,0 +1,2 @@ | |||
#!/bin/sh | |||
exec /usr/bin/mongod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the application container be running mongodb? Normally I would run mongo in a separate container/standalone service.
Having it embedded in the application container makes it harder to have persistent data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Persistent storage is already possible, in two specific ways:
- One can update the
config/config.default.php
file with the correct mongo address. This keeps the in-container mongo instance running, but does not use it. - One can run with the in-container mongo instance, but use a docker volume for that:
docker run -v $(pwd)/mongo-data:/data/db
).
Would it suffice if I add a README.md file in the docker/
folder specifying these options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you could do those things, but you will not be able to restart or manage the in-container mongo at all though, and when not in use it will burn a non-zero amount of resources.
Is there a reason to not use docker-compose
? It sets the user up for success better in the future.
Hi, just quick note to assure you that I haven't forgotten about this. I'm currently unable to work on it, but I expect to be able to address the comments within a month. |
@jacobkiers I've not forgotten either. I'm the midst of a bunch of work for some of my other projects, and hope to circle back on this after that is complete. |
this looked stale, and I wanted to use official images with multi containers, so I created: first I tried to add my commits on top of this branch, but as there remained no common changes, rebased with only my commits. |
As a convenience to easily run and deploy XHGui, I'd like this docker support to be merged.