Working on #151 #243
Working on #151 #243
Conversation
| @@ -55,7 +55,7 @@ | |||
| </a> | |||
| </td> | |||
| <td> | |||
| {% set addr = result.meta.url %} | |||
| {% set addr = result.meta('SERVER.SERVER_NAME') ~ result.meta.url %} | |||
There was a problem hiding this comment.
Won't this be the server that xhgui is running on? That isn't necessarily the same server/host that the profile data was collected from.
There was a problem hiding this comment.
As I saw show the right domain and not the server one.
There was a problem hiding this comment.
You're right. I misread the code earlier.
|
@markstory about how to pass the domain on https://github.com/perftools/xhgui/blob/master/src/Xhgui/Controller/Run.php#L186 to improve also the single view of the profile running do you have any hints |
|
Wouldn't the profile have the host name in its metadata again? |
|
As I saw there is the https://github.com/perftools/xhgui/blob/master/src/Xhgui/Controller/Run.php#L186 that share only few specific info and I don't know how to pass also the server name so I can reuse that value also on the frontend to show the domain. |
|
The first |
|
AS I can see share https://github.com/perftools/xhgui/blob/master/src/Xhgui/Controller/Run.php#L185 only |
Right now show the domain in the list but not in the pages.
I am not sure about how to pass the domain on https://github.com/perftools/xhgui/blob/master/src/Xhgui/Controller/Run.php#L186