Use POST for /runs/delete_all and add a confirmation form #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but the tests need to be updated as well. |
Krinkle
added a commit
to Krinkle/xhgui
that referenced
this pull request
Jan 4, 2019
The tests at https://travis-ci.org/perftools/xhgui/builds/475018345 for perftools#252 are passing on for "PHP 7" and on "PHP 5 Coverage", which doesn't make sense.
Krinkle
added a commit
to Krinkle/xhgui
that referenced
this pull request
Jan 4, 2019
The tests at https://travis-ci.org/perftools/xhgui/builds/475018345 for perftools#252 are passing on for "PHP 7" and on "PHP 5 Coverage", which doesn't make sense.
Krinkle
added a commit
to Krinkle/xhgui
that referenced
this pull request
Jan 4, 2019
The tests at https://travis-ci.org/perftools/xhgui/builds/475018345 for perftools#252 are passing on for "PHP 7" and on "PHP 5 Coverage", which doesn't make sense.
* The confirmation form avoids mistakes. It can currently be pressed by accident when using a less-than-ideal pointer device, such as a touch screen, or keyboard focus. * The POST verb allows it to be denied or require auth based on verb-based server configuration, as was already the case for the only other write-method previously (/watch). I'll do the same for /run/delete?id in a future commit. Ref perftools#248.
Krinkle
force-pushed
the
post-deleteall
branch
from
003e74e
to
ebde052
Compare
Krinkle
added a commit
to Krinkle/xhgui
that referenced
this pull request
Jan 4, 2019
The tests at https://travis-ci.org/perftools/xhgui/builds/475018345 for perftools#252 are passing on for "PHP 7" and on "PHP 5 Coverage", which doesn't make sense.
Krinkle
added a commit
to Krinkle/xhgui
that referenced
this pull request
Jan 4, 2019
The tests at https://travis-ci.org/perftools/xhgui/builds/475018345 for perftools#252 are passing on for "PHP 7" and on "PHP 5 Coverage", which doesn't make sense.
|
Ah, forgot about those. Done now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The confirmation form avoids mistakes. It can currently be pressed
by accident when using a less-than-ideal pointer device, such as
a touch screen, or keyboard focus.
The POST verb allows it to be denied or require auth based on
verb-based server configuration, as was already the case for
the only other write-method previously (/watch). I'll do
the same for /run/delete?id in a future commit.
Ref #248.