Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code coverage reporting #256

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Conversation

Krinkle
Copy link
Contributor

@Krinkle Krinkle commented Jan 7, 2019

[phpunit]
Error: Incorrect whitelist config, no code coverage will be generated.

Looks like somewhere along the way, the format for PHPUnit
changed, however, it's not an error that produces a non-zero
exit code, so I missed this.

The ocular.phar command also prints an error, and also without
non-zero exit code, hence making it hard to find when passing.

[ocular.phar]
Notifying that no code coverage data is available.

> [phpunit]
> Error:         Incorrect whitelist config, no code coverage will be generated.

Looks like somewhere along the way, the format for PHPUnit
changed, however, it's not an error that produces a non-zero
exit code, so I missed this.

The ocular.phar command also prints an error, and also without
non-zero exit code, hence making it hard to find when passing.

> [ocular.phar]
> Notifying that no code coverage data is available.
@markstory markstory merged commit 2965240 into perftools:master Jan 7, 2019
@Krinkle Krinkle deleted the coverage branch January 7, 2019 23:17
@glensc glensc mentioned this pull request Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants