Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use POST for /run/delete and add confirmation form #257

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Use POST for /run/delete and add confirmation form #257

merged 1 commit into from
Jan 9, 2019

Conversation

Krinkle
Copy link
Contributor

@Krinkle Krinkle commented Jan 8, 2019 •
edited
Loading

Fixes #248.

@markstory
Copy link
Member

Looks good, but tests are failing.

@Krinkle
Copy link
Contributor Author

Krinkle commented Jan 9, 2019

I strangely keep forgetting that on this project. Sorry about that. Fixed now.

@markstory markstory merged commit f039fb9 into perftools:master Jan 9, 2019
@Krinkle Krinkle deleted the post-delete branch January 19, 2019 02:59
@glensc glensc mentioned this pull request Jun 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Krinkle @markstory