Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by methods #265

Merged
merged 10 commits into from
Apr 15, 2019
Merged

Filter by methods #265

merged 10 commits into from
Apr 15, 2019

Conversation

Mte90
Copy link
Contributor

@Mte90 Mte90 commented Apr 8, 2019

Start from #237 and rewritten to add a new support.
Now other match the exact method/function support regular expression like from Composer* so all the method/function that fit this expression are removed.

Looking at the code now to filter the data is required to /run/view?id=5cab781f51dc5f34fa735812&filter to add a filter parameter in the URL or this code will be not executed.

Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have some tests covering what this does.

src/Xhgui/Profile.php Outdated Show resolved Hide resolved
src/Xhgui/Profile.php Outdated Show resolved Hide resolved
src/Xhgui/Profile.php Outdated Show resolved Hide resolved
@Mte90
Copy link
Contributor Author

Mte90 commented Apr 8, 2019

For tests I have to prepare a dev environment but I will do them :-)

@Mte90
Copy link
Contributor Author

Mte90 commented Apr 10, 2019

Started working on tests but not yet finished, required a bit with issue on docker on my system.

@Mte90
Copy link
Contributor Author

Mte90 commented Apr 11, 2019

3 new unit tests added :-)
Let me know if it is missing something!

@markstory markstory merged commit 022281a into perftools:master Apr 15, 2019
@glensc glensc mentioned this pull request Jun 19, 2020
@glensc glensc mentioned this pull request Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants