Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add url prefix config support #298

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Add url prefix config support #298

merged 2 commits into from
Jul 21, 2020

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Jul 16, 2020 •
edited
Loading

For backward compatibility, if the option is not defined, previous behavior is used.

@glensc glensc self-assigned this Jul 16, 2020
@glensc glensc marked this pull request as ready for review July 16, 2020 07:13
@glensc
Copy link
Contributor Author

glensc commented Jul 16, 2020

In my environment (the docker image we provide), the previous logic always returned "" for base URL, as SCRIPT_NAME is always "". I just left it as is, as it seems broken and too fragile to touch.

@glensc glensc mentioned this pull request Jul 16, 2020
Merged
@markstory markstory merged commit d9133bf into perftools:master Jul 21, 2020
@glensc glensc deleted the url-prefix branch July 23, 2020 07:14
@glensc glensc mentioned this pull request Aug 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glensc glensc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glensc @markstory