Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement URL filter and pagination when using PDO #304

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

dpifke
Copy link

@dpifke dpifke commented Aug 16, 2020

Fixes #303.

@glensc
Copy link
Contributor

glensc commented Aug 17, 2020

@dpifke does this solve any open issue? please indicate so in PR body if that is so.

@glensc glensc marked this pull request as draft August 19, 2020 07:27
src/Xhgui/Searcher/Pdo.php Outdated Show resolved Hide resolved
@glensc glensc mentioned this pull request Aug 19, 2020
@glensc
Copy link
Contributor

glensc commented Aug 19, 2020

you shouldn't put two changesets to one PR. the one suitable for merge extracted as separate PR: #306 (rebase once it's merged), the other changeset requires changes before merge.

@dpifke
Copy link
Author

dpifke commented Aug 20, 2020

you shouldn't put two changesets to one PR. the one suitable for merge extracted as separate PR: #306 (rebase once it's merged), the other changeset requires changes before merge.

My understanding is that there isn't a way to make one PR in Github dependent on another. The fix for PDO argument ordering was required for this to function at all.

Bug: T260397
Change-Id: I9ca3826a02090aec9ff9b4bd3d88e2dafd012c5e
@glensc
Copy link
Contributor

glensc commented Aug 21, 2020

My understanding is that there isn't a way to make one PR in Github dependent on another. The fix for PDO argument ordering was required for this to function at all.

have you tried changing "target branch"? works in gitlab. but you can always indicate dependency in merge request body and use "work in progress" state to prevent early merge.

@glensc glensc marked this pull request as ready for review August 21, 2020 07:26
@glensc glensc merged commit 46e4e8d into perftools:master Aug 21, 2020
@dpifke dpifke deleted the pagination branch August 22, 2020 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support basic url filter with PDO backend
2 participants