Encode dot in MongoDB saver as underscore #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This ended up in 0.16.0 release |
glensc
added a commit
to perftools/php-profiler
that referenced
this pull request
Jan 19, 2021
As the perftools/xhgui-collector package will no longer be updated, do the change in perftools/php-profiler package This duplicates same fix in xhgui itself: - perftools/xhgui#352 Users are encouraged to switch to file or upload savers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to use ASCII
_instead of Unicode values to avoid further surprises. And the value is used just for display purposes, so doesn't matter what it really is.