Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Mapper methods to satisfy codestyle #368

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Rename Mapper methods to satisfy codestyle #368

merged 1 commit into from
Oct 30, 2020

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Oct 30, 2020

These were complained by @stickler-ci:

Check failure on line 41 in src/Xhgui/Db/Mapper.php

src/Xhgui/Db/Mapper.php#L41
Method name "_conditions" should not be prefixed with an underscore to indicate visibility

@glensc glensc self-assigned this Oct 30, 2020
@glensc glensc merged commit e7d4d21 into master Oct 30, 2020
@glensc glensc deleted the method-names branch October 30, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glensc glensc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@glensc