-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add render() method to be called from controllers #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glensc
force-pushed
the
render-method
branch
3 times, most recently
from
December 22, 2020 22:56
5186957
to
a50fa6f
Compare
glensc
force-pushed
the
render-method
branch
3 times, most recently
from
December 22, 2020 23:45
bfb1757
to
8a5febf
Compare
glensc
force-pushed
the
render-method
branch
2 times, most recently
from
December 22, 2020 23:52
6a01acd
to
ab88068
Compare
glensc
force-pushed
the
render-method
branch
from
December 22, 2020 23:54
ab88068
to
59a78f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update each route to return a
Response
, or update $response. This is the pattern to be used and without magic.This undoes the middleware for render:
I believe the original purpose was to able to test controllers behavior, this problem is solved by fetching
all()
from view:In fact, this brought up a problem that tests did not even use proper View. Tests used default
\Slim\View
not\Slim\Views\Twig
and that View did not have template extensions present.