Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop SessionCookie middleware #401

Merged
merged 1 commit into from
Dec 25, 2020
Merged

Drop SessionCookie middleware #401

merged 1 commit into from
Dec 25, 2020

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Dec 23, 2020

It was added in 0041530

I believe it's no used, therefore dropping to ease Slim v3 migration.

@glensc glensc self-assigned this Dec 23, 2020
@glensc glensc marked this pull request as ready for review December 23, 2020 16:06
@glensc glensc added this to the Next milestone Dec 25, 2020
@glensc glensc merged commit 080cd19 into master Dec 25, 2020
@glensc glensc deleted the no-sessions branch December 25, 2020 14:22
@glensc glensc mentioned this pull request Jan 22, 2021
Merged
@glensc
Copy link
Contributor Author

glensc commented Jan 22, 2021

Started session appears to be needed for flash messages:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markstory markstory markstory approved these changes

Assignees

@glensc glensc

Labels
None yet
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@glensc @markstory