Saver: Drop "get" key requirement from profiler data on submit #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The "url" for CLI may fail here: need to ensure empty as the CI passed, that means that scenario is not in phpunit. |
|
Looks like the test fixture is even out of sync, "url" has get parameters but "get" is empty: |
glensc
force-pushed
the
saver-redundant-get
branch
from
c823366
to
88f5322
Compare
Profiler no longer needs to send "get" over the wire. The individual savers may choose not to store this down separately. - Update NormalizingSaver test - Remove redundant "get" from results.json
glensc
force-pushed
the
saver-redundant-get
branch
from
88f5322
to
f69be0f
Compare
glensc
changed the title
markstory
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop "get" key from profiler data when it's submitted. The value is now extracted from "url", so sending "get" data is redundant.
Profiler no longer needs to send "get" over the wire.
The individual savers may choose not to store this down separately.