Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sql type text by longtext for profile field in PdoRepository #437

Closed
wants to merge 1 commit into from

Conversation

mkeromen
Copy link

@mkeromen mkeromen commented Nov 7, 2021

  • Fix to avoid truncated data with XHGui\Saver\PdoSaver

@glensc glensc changed the base branch from 0.20.x to 0.19.x November 7, 2021 21:47
@glensc glensc changed the title [Fix 0.20.x] Replace sql type text by longtext for profile field in PdoRepository Replace sql type text by longtext for profile field in PdoRepository Nov 7, 2021
@glensc glensc added this to the 0.19.1 milestone Nov 7, 2021
@glensc
Copy link
Contributor

glensc commented Nov 7, 2021

1) XHGui\Test\Controller\RunTest::testIndexEmpty
PDOException: SQLSTATE[42704]: Undefined object: 7 ERROR:  type "longtext" does not exist
LINE 4:               "profile"          LONGTEXT       NOT NULL,

looks like this is database dependent, so far we've avoided abstracting database type:

@glensc
Copy link
Contributor

glensc commented Nov 7, 2021

I've added the driver name to the repository class:

so this could be evaluated to make driver-specific changes

@glensc
Copy link
Contributor

glensc commented Nov 7, 2021

Rebased and changed target branch, so pay attention to update your local branch first if you add more commits to this branch

@glensc glensc mentioned this pull request Nov 11, 2021
@glensc
Copy link
Contributor

glensc commented Dec 20, 2021

@mkeromen close, since you're no longer interested in this?

@glensc glensc removed this from the 0.19.1 milestone Jan 16, 2022
@Charl13
Copy link

Charl13 commented Mar 2, 2022

@glensc This is actually rather important since json_decode() silently returns null on truncated data. That means no error and empty results in the callgraph. Harder to debug.

@glensc
Copy link
Contributor

glensc commented Mar 2, 2022

Closing, as seems the original author is not interested in finishing this.

@glensc glensc closed this Mar 2, 2022
@Charl13
Copy link

Charl13 commented Mar 2, 2022

@glensc What about my comment? Do you want me to open a new pull request?

@glensc
Copy link
Contributor

glensc commented Mar 2, 2022

@Charl13 up to you

@Charl13
Copy link

Charl13 commented Mar 2, 2022

#474 🙏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants