Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perftools/php-profiler link #468

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Fix perftools/php-profiler link #468

merged 2 commits into from
Feb 25, 2022

Conversation

kornrunner
Copy link
Contributor

Changed syntax as [perftools/php-profiler] alias was already defined in the file.

…0.21.x_8DJVRORb

Merge release 0.20.1 into 0.21.x
@glensc
Copy link
Contributor

glensc commented Feb 16, 2022

Pardon, but what is the problem you are trying to solve here? and I prefer markdown reflinks for readability. Describe the problem first.

@kornrunner
Copy link
Contributor Author

kornrunner commented Feb 16, 2022

Both [perftools/php-profiler] anchors that are rendered on Github repository page (Readme.md) actually link to https://github.com/perftools/xhgui#profiling-a-web-request-or-cli-script which is the value of first markdown reflink.

It seems that Github doesn't process markdown reflink redefinition - thus second link is not linking to the repository page as one might expect (the one being changed within this PR).

@glensc
Copy link
Contributor

glensc commented Feb 16, 2022

perhaps the first link should link to the section in the readme, i.e:

[bla bla bla](#profiling-a-web-request-or-cli-script)

@kornrunner
Copy link
Contributor Author

Updated first link

@glensc glensc changed the base branch from 0.21.x to 0.20.x February 25, 2022 15:48
@glensc glensc merged commit 5b8516b into perftools:0.20.x Feb 25, 2022
@glensc glensc added this to the 0.20.4 milestone Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants