-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gpioutil: Note that Debounce is not implemented #10
Conversation
Codecov Report
@@ Coverage Diff @@
## main #10 +/- ##
=====================================
Coverage 98.3% 98.3%
=====================================
Files 31 31
Lines 2699 2699
=====================================
Hits 2652 2652
Misses 44 44
Partials 3 3
Continue to review full report at Codecov.
|
Humm it seems like I messed up the CI, I'll have to double check. |
Thinking about it more I think it's because my canary testing trick to fetch a not-yet-merged-commit works but only for commits in branches but not for PRs. I will have to fix this. In the meantime I'll just do a quick check how it looks in local godoc and will merge later ignoring the CI failure. |
Sorry for the delay, the reason is that I wanted to confirm how it looks in godoc, compare the current layout: versus moving stuff around: The second works by putting warning on a single line. I also feel putting it at the end of the description instead of the middle flows better for the reader. The rationale is that vast majority of the users will be using the online view at pkg.go.dev, only a minority will read the code. That's why I'm a bit picky about how it renders. |
Doc for the second form:
|
Makes sense, done. |
Fixes #8