Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display: Create Interfaces for text displays #42

Merged
merged 10 commits into from
Jan 12, 2025
Merged

Conversation

gsexton
Copy link
Contributor

@gsexton gsexton commented Dec 21, 2024

This creates a set of interfaces for use by text oriented displays like LCDs. Ultimately, I'm planning on adding multiple backpacks for hd44780, the Sparkfun SerLCD, MatrixOrbital LK204-7T, Adafruit USB LCD backpack (compatible w/ MatrixOrbital), and an SSH1106 OLED.

The arch for the backpacks will be a backpack that accepts a gpio.Group(). Then, I'll have implementations (MCP23008, 8574T, gpioioctl.LineSet, and sets of GPIO pins.

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 169 lines in your changes missing coverage. Please review.

Project coverage is 93.7%. Comparing base (1a89f8f) to head (a849c37).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
display/displaytest/text.go 0.0% 169 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #42     +/-   ##
=======================================
- Coverage   97.9%   93.7%   -4.2%     
=======================================
  Files         33      34      +1     
  Lines       3760    3930    +170     
=======================================
+ Hits        3680    3681      +1     
- Misses        75     244    +169     
  Partials       5       5             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One proposal for the argument interactive -> pauseTime but I don't have a strong opinion.

display/displaytest/text.go Outdated Show resolved Hide resolved
display/displaytest/text.go Outdated Show resolved Hide resolved
display/text_display.go Show resolved Hide resolved
Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maruel maruel merged commit e01555d into periph:main Jan 12, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants