waveshare2in13v2: Add constants, add missing init to example #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmt.Sprintf() can format numbers directly using the "%d" format specifier. Signed-off-by: Michael Hanselmann <public@hansmi.ch>
maruel
reviewed
Nov 25, 2021
waveshare2in13v2/example_test.go
Outdated
| log.Fatalf("Failed to initialize driver: %v", err) | ||
| } | ||
|
|
||
| if err := dev.Init(false); err != nil { |
waveshare2in13v2/waveshare213v2.go
Outdated
| setDummyLinePeriod byte = 0x3A | ||
| setGateTime byte = 0x3B | ||
| borderWaveformControl byte = 0x3C | ||
| unknownCommand37 byte = 0x37 |
There was a problem hiding this comment.
Was it listed in the datasheet or not?
There was a problem hiding this comment.
Ah, this was a leftover from an earlier revision. No, this particular command isn't documented anywhree. I removed the constant again.
Without initializing the hardware nothing is shown on the display. Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Translate the command names from the datasheet into constant names, similar to `epd/epd.go`. These names make it easier to understand what the driver does. One command, 0x37, is not documented in any of the datasheets available (Waveshare 2.13inch e-Paper, Good Display GDEH0213B72). Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Codecov Report
@@ Coverage Diff @@
## main #25 +/- ##
=====================================
Coverage 60.3% 60.3%
=====================================
Files 48 48
Lines 6454 6453 -1
=====================================
Hits 3893 3893
+ Misses 2426 2425 -1
Partials 135 135
Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate magic numbers to named constants based on datasheet and add missing calls to
dev.Initin example code.