Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go version in go.mod and for quick tests to 1.14 #29

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Bump Go version in go.mod and for quick tests to 1.14 #29

merged 1 commit into from
Dec 3, 2021

Conversation

hansmi
Copy link
Contributor

@hansmi hansmi commented Dec 3, 2021

Go 1.13 was released in September 2019, more than two years ago.
Updating to one later release should be fine.

The primary reason for doing this is the introduction of
"testing".T.Cleanup in Go 1.14 (https://pkg.go.dev/testing#T.Cleanup).

.github/workflows/test.yml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #29 (0ac8d15) into main (d09d487) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main     #29     +/-   ##
=======================================
- Coverage   60.4%   60.3%   -0.0%     
=======================================
  Files         48      48             
  Lines       6453    6453             
=======================================
- Hits        3895    3893      -2     
- Misses      2423    2425      +2     
  Partials     135     135             
Impacted Files Coverage Δ
as7262/as7262.go 98.6% <0.0%> (-0.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09d487...0ac8d15. Read the comment docs.

Go 1.13 was released in September 2019, more than two years ago.
Updating to one later release should be fine.

The primary reason for doing this is the introduction of
"testing".T.Cleanup in Go 1.14 (https://pkg.go.dev/testing#T.Cleanup).

Signed-off-by: Michael Hanselmann <public@hansmi.ch>
@maruel maruel merged commit 02831f4 into periph:main Dec 3, 2021
@maruel
Copy link
Member

maruel commented Dec 3, 2021

Thanks!

@hansmi hansmi deleted the minver1 branch December 11, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants