waveshare2in13v2: Add function for deep sleep, update both buffers on clear #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The datasheets of the comparable SSD1680, SSD1675B and GDEH0213B73 controllers describe this command as "Write register for display option". Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Enable the clock and analog parts when configuring the mode. In probably all use cases a drawing operation is following soon after anyway. Putting the device to sleep disables these hardware parts again.
Move the logic applying display content changes to both buffers to the "drawImage" function.
With the introduction of the shadow buffer in commit 4f99575 there's always a sufficiently large memory buffer to keep the bytes to send for clearing and the dedicated code using a smaller buffer is no longer needed. This also has the advantage of automatically updating both on-device buffers.
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
=======================================
- Coverage 63.6% 63.5% -0.1%
=======================================
Files 56 56
Lines 6727 6706 -21
=======================================
- Hits 4279 4260 -19
+ Misses 2307 2304 -3
- Partials 141 142 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a named constant for the previously unknown 0x37 command, tweak when hardware is enabled, add a function to put display to sleep and clear both buffers.