Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ep0099: optionally read device state on new #86

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

freman
Copy link
Contributor

@freman freman commented Dec 20, 2024

Add new structure (Opts) and 2 new methods (NewWithOpts, ReadStates) to provide the ability to load the state from the device instead of simply resetting the device on start.

Promoted Reset() to be a public function so it can be called to reset the state if required.

@freman freman changed the title ep0099: optionally read device state on init ep0099: optionally read device state on new Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.5%. Comparing base (72857e8) to head (7978e3c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ep0099/ep0099.go 77.8% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #86     +/-   ##
=======================================
+ Coverage   49.4%   49.5%   +0.1%     
=======================================
  Files         90      90             
  Lines      11721   11736     +15     
=======================================
+ Hits        5794    5808     +14     
  Misses      5674    5674             
- Partials     253     254      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maruel maruel merged commit cfd565d into periph:main Dec 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants